Re: Distinguishing FF vs non-FF updates in the reflog?

From: Martin Fick <mfick@codeaurora.org>
Date: Mar 17, 2021, 21:21 UTC
Message-ID: <5359503.g8GvsOHjsp@mfick-lnx>
In-Reply-To: <CAFQ2z_MefCwiWdhs0buJv5Zok+nsgaOvUCcsSnfm_PP0WozZKA@mail.gmail.com>

On Wednesday, March 17, 2021 9:06:06 PM MDT Han-Wen Nienhuys wrote:

Show 5 quoted lines

> I'm working on some extensions to Gerrit for which it would be very
> beneficial if we could tell from the reflog if an update is a
> fast-forward or not: if we find a SHA1 in the reflog, and see there
> were only FF updates since, we can be sure that the SHA1 is reachable
> from the branch, without having to open packfiles and decode commits.

I don't think this would be reliable.

1) Not all updates make it to the reflogs
2) Reflogs can be edited or mucked with
3) On NFS reflogs can outright be wrong even when used properly as their are 
caching issues. We specifically have seen entries that appear to be FFs that 
were not.

I believe that today git can do very fast reachability checks without opening pack files by using some of its indexes (bitmap code or https://git-scm.com/ docs/commit-graph ?). It probably makes sense to add this ability to jgit if that is what you need?

-Martin

-- 
The Qualcomm Innovation Center, Inc. is a member of Code 
Aurora Forum, hosted by The Linux Foundation