Re: [PATCH] git-rebase: fix probable reflog typo

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Apr 23, 2014, 21:22 UTC
Message-ID: <53582f33385bc_24448772ec57@nysa.notmuch>
In-Reply-To: <vpqy4ywxoos.fsf@anie.imag.fr>

Matthieu Moy wrote:

Show 8 quoted lines

> Felipe Contreras <felipe.contreras@gmail.com> writes:
> 
> > Commit 26cd160 (rebase -i: use a better reflog message) tried to produce
> > a better reflog message, however, it seems a statement was introduced by
> > mistake.
> >
> > 'comment_for_reflog start' basically overides the GIT_REFLOG_ACTION we
> > just set.

> So, one needs to reset $GIT_REFLOG_ACTION to what it used to be if is it
> to be used later. However, it seems to me that the "comment_for_reflog
> start" is used only for this checkout command. If so, there's no need
> for the "comment_for_reflog start" before the if statement either.

Exactly. But if this variable is only meant for this command, it should be `VAR=VAL command`, that would make it clear without the need of a comment.

-- 
Felipe Contreras