Re: [PATCH] update-ref: fail create operation over stdin if ref already exists

From: Brad King <brad.king@kitware.com>
Date: Apr 2, 2014, 12:57 UTC
Message-ID: <533C092B.1050801@kitware.com>
In-Reply-To: <1396426194-3292-1-git-send-email-mhagger@alum.mit.edu>

On 04/02/2014 04:09 AM, Michael Haggerty wrote:

> From: Aman Gupta <aman@tmm1.net>

[snip]

Show 5 quoted lines

> @@ -147,6 +147,7 @@ static void parse_cmd_create(const char *next)
>  	struct ref_update *update;
>  
>  	update = update_alloc();
> +	update->have_old = 1;

Looks good.

> +test_expect_success 'stdin -z create ref fails when ref exists' '

Strictly speaking we should have a non-z mode test too.

Thanks, -Brad