Re: [PATCH] rev-parse --parseopt: option argument name hints

From: Ilya Bobyr <ilya.bobyr@gmail.com>
Date: Mar 20, 2014, 08:38 UTC
Message-ID: <532AA923.6030409@gmail.com>
In-Reply-To: <xmqq61na3u2m.fsf@gitster.dls.corp.google.com>

On 3/19/2014 11:46 AM, Junio C Hamano wrote:

Show 22 quoted lines

> Ilya Bobyr <ilya.bobyr@gmail.com> writes:
>
>> I can not find this particular patch in the latest "What's cooking" email.
>> Is there something I can do?
> IIRC, I think I was waiting for the version with a new "Usage text"
> section to the documentation you alluded to in this exchange
> ($gmane/243924):
>
>      Ilya Bobyr <ilya.bobyr@gmail.com> writes:
>
>      > On 3/11/2014 12:10 PM, Junio C Hamano wrote:
>      >>
>      >>>> Documentation on the whole argument parsing is quite short, so,...
>      > ...
>      > I though that an example just to describe `argh' while useful would
>      > look a bit disproportional, compared to the amount of text on
>      > --parseopt.
>      >
>      > But now that I've added a "Usage text" section to looks quite in place.
>      >
>      > I just realized that the second patch I sent did not contain the
>      > changes.  Sorry about - I will resend it.

Oh %) I did sent it in the next minute. And did receive a copy myself. But it seems it never showed up in the list. I am still a bit new to the tools, maybe I did something wrong. Will try again :)

Show 9 quoted lines

>> It does not seems like there is a lot of interest, so I am not sure
>> there will be a lot of discussion.
>> It is a minor fix and considering the number of the emails on the
>> list, I do not unexpected this kind of stuff to be very popular.
>> But it seems like a valid improvement to me.
>> Maybe I am missing something?
> You did the right thing by sending a reminder message with a pointer
> to help others locate the original (like the one I am responding
> to), as nobody can keep up with a busy list traffic.

Thanks :)

Show 11 quoted lines

>> Same questions about this one:
>>
>>      [PATCH] gitk: replace SHA1 entry field on keyboard paste
>>      http://www.mail-archive.com/git@vger.kernel.org/msg45040.html
>>
>> I think they are more or less similar, except that the second one is
>> just trivial.
> I do not remember if I forwarded the patch to the area maintainer
> Paul Mackerras <paulus@samba.org>, but if I didn't please do so
> yourself.  The changes to gitk and git-gui come to me via their own
> project repositories.

You did and I even replied with additional details, that I should have included as a cover letter. I can see those messages in the web archive. It seems that Paul Mackerras gitk repository is here: git://ozlabs.org/~paulus/gitk.git At least that is what is online. I do not see the change in there. I will remind him about it.