Re: [PATCH] add: Use struct argv_array in run_add_interactive()

From: Fabian Ruch <bafain@gmail.com>
Date: Mar 15, 2014, 12:41 UTC
Message-ID: <53244A95.8050308@gmail.com>
In-Reply-To: <53243620.8080401@gmail.com>

On 03/15/2014 12:14 PM, Fabian Ruch wrote:

Show 8 quoted lines

> run_add_interactive() in builtin/add.c manually computes array bounds
> and allocates a static args array to build the add--interactive command
> line, which is error-prone. Use the argv-array helper functions instead.
> 
> Signed-off-by: Fabian Ruch <bafain@gmail.com>
> ---
>  builtin/add.c | 21 ++++++++++-----------
>  1 file changed, 10 insertions(+), 11 deletions(-)

I should mention that I am applying to this year's edition of Google's Summer of Code.