git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2] branch: change install_branch_config() to use skip_prefix()

From
DDDmitry S. Dolzhenko <dmitrys.dolzhenko@yandex.ru>
Date
Feb 27, 2014, 15:35 UTC
Message-ID
<530F5B41.1050900@yandex.ru>

Change install_branch_config() to use skip_prefix() for getting the short name of the remote branch.

Signed-off-by: Dmitry S. Dolzhenko <dmitrys.dolzhenko@yandex.ru>
---
 branch.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/branch.c b/branch.c
index 723a36b..9382e02 100644
--- a/branch.c
+++ b/branch.c
@@ -49,8 +49,8 @@ static int should_setup_rebase(const char *origin)
 
 void install_branch_config(int flag, const char *local, const char *origin, const char *remote)
 {
-	const char *shortname = remote + 11;
-	int remote_is_branch = starts_with(remote, "refs/heads/");
+	const char *shortname = skip_prefix(remote, "refs/heads/");
+	int remote_is_branch = shortname != NULL;
 	struct strbuf key = STRBUF_INIT;
 	int rebasing = should_setup_rebase(origin);
 
-- 
1.8.3.2
Next: Junio C Hamano
Message 1 of 3 in “branch: change install_branch_config() to use skip_prefix()”
  1. branch: change install_branch_config() to use skip_prefix()Dmitry S. Dolzhenko, Feb 27, 2014
  2. Junio C HamanoFeb 27, 2014
  3. Junio C HamanoFeb 27, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.