Re: [PATCH] Correct compile errors when DEBUG_BISECT=1 after supporting other hash algorithms

From: Stephan Beyer <s-beyer@gmx.net>
Date: Mar 29, 2017, 21:36 UTC
Message-ID: <52ac188d-1112-758e-5d02-470afc6ffa8d@gmx.net>
In-Reply-To: <CAMX8fZXS4k5chezESM4pcaSfhG6WZ4xKxsWB0fpm4h-PQGjXwQ@mail.gmail.com>

Hi,

On 03/29/2017 10:02 PM, Alex Hoffman wrote:

> Any news about this patch?

Haha nice, your initial patch is the same as mine (but mine was part of a bigger patch series and the v3 is probably going to have one less commit): https://public-inbox.org/git/1456452282-10325-4-git-send-email-s-beyer@gmx.net/

>>                 for (pp = commit->parents; pp; pp = pp->next)
>>                         fprintf(stderr, " %.*s", 8,
>> -                               sha1_to_hex(pp->item->object.sha1));
>> +                                       oid_to_hex(&pp->item->object.oid));

I guess your change in continued indentation is intentional, but is it just my mail client or do you f*ck up tabs? (I haven't tried to apply the patch but it looks like it is not possible due to broken tabs.)

Stephan