git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: git rm / format-patch / am fails on my file: patch does not apply

From
Stefan Beller <stefanbeller@googlemail.com>
Date
Nov 11, 2013, 19:43 UTC
Message-ID
<5281336F.7070103@googlemail.com>
In-Reply-To
<xmqqd2m6logx.fsf@gitster.dls.corp.google.com>
On 11.11.2013 20:37, Junio C Hamano wrote:
Show 9 quoted lines
> Stefan Beller <stefanbeller@googlemail.com> writes:
> 
>> I do have this global config
>> 	core.safecrlf=warn
>> regarding line endings.
> 
> Oh, that sounds very suspicious.  If the payload has CRLF, CR and LF
> mixed, that would immediately violate safecrlf, so failing the
> application sounds like the right thing to do.

Not having read the man page, but copied this global config from some '1000 git tips in 5 minutes' years ago, I do expect a setting set to "warn" to actually not change the program flow except some inserted prints with warnings.

Show 7 quoted lines
> 
>> I was using 1.8.5.rc1.17.g0ecd94d
>>
>> Trying to understand the problem,
> 
> Likewise.  Thanks for chiming in.
> 

Looking at the file we have a mixture of LF/CR, LF only and CR only ending the lines. The formatted patch does have the same file endings on the respective line of that file here.

I was trying to change just one line ending to 2 lines (LF CR -> LF LF) with a hex editor, so there it becomes a smaller (and more debugable ) patch. I also tried LF -> CR and CR -> LF, but none of these small changes seem to work.

Stefan
Previous: Junio C HamanoNext: Stefan Beller
Message 5 of 10 in “git rm / format-patch / am fails on my file: patch does not apply”
  1. Ken TanzerNov 11, 2013
  2. Junio C HamanoNov 11, 2013
  3. Stefan BellerNov 11, 2013
  4. Junio C HamanoNov 11, 2013
  5. Stefan BellerNov 11, 2013
  6. Stefan BellerNov 11, 2013
  7. Ken TanzerNov 13, 2013
  8. Junio C HamanoNov 13, 2013
  9. Philip OakleyNov 13, 2013
  10. Ken TanzerNov 14, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.