git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/5] fix up 'jk/pack-bitmap' branch

From
Torsten Bögershausen <tboegi@web.de>
Date
Nov 9, 2013, 11:35 UTC
Message-ID
<527E1DED.9030800@web.de>
In-Reply-To
<20131108222903.GB19912@sigill.intra.peff.net>
On 2013-11-08 23.29, Jeff King wrote:
Show 11 quoted lines
> On Fri, Nov 08, 2013 at 06:10:30PM +0100, Torsten Bögershausen wrote:
> 
>> Side question:
>> Do we have enough test coverage for htonll()/ntohll(),
>> or do we want do the "module test" which I send a couple of days before ?
> 
> The series adds tests for building and using the ewah bitmaps, which in
> turn rely on the htonll code. So they are being tested in the existing
> series.
> 
> -Peff

You are thinking about t5310-pack-bitmaps.sh ? If I do like this in compat/bswap.h

# define ntohll(n) (n) # define htonll(n) (n) (on an Intel processor, little endian)

then t5310 passes, even if the uint64_t words are written in little endian to disc instead of big endian.

What do I miss? /torsten

Previous: Jeff KingNext: Johannes Sixt
Message 7 of 10 in “fix up 'jk/pack-bitmap' branch”
  1. 0/5 fix up 'jk/pack-bitmap' branchRamsay Jones, Nov 7, 2013
  2. Jeff KingNov 7, 2013
  3. Vicent MartíNov 8, 2013
  4. Torsten BögershausenNov 8, 2013
  5. Ramsay JonesNov 8, 2013
  6. Jeff KingNov 8, 2013
  7. Torsten BögershausenNov 9, 2013
  8. Johannes SixtNov 9, 2013
  9. Thomas RastNov 9, 2013
  10. Jeff KingNov 9, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.