git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 4/5] pack-objects: Limit visibility of 'indexed_commits' symbols

From
Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Date
Nov 7, 2013, 22:11 UTC
Message-ID
<527C100A.6030907@ramsay1.demon.co.uk>

Noticed by sparse. ("symbol '...' was not declared. Should it be static?")

Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
---
 builtin/pack-objects.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/builtin/pack-objects.c b/builtin/pack-objects.c
index 423e85a..161bfc2 100644
--- a/builtin/pack-objects.c
+++ b/builtin/pack-objects.c
@@ -85,9 +85,9 @@ static uint32_t reused, reused_delta;
 /*
  * Indexed commits
  */
-struct commit **indexed_commits;
-unsigned int indexed_commits_nr;
-unsigned int indexed_commits_alloc;
+static struct commit **indexed_commits;
+static unsigned int indexed_commits_nr;
+static unsigned int indexed_commits_alloc;
 
 static void index_commit_for_bitmap(struct commit *commit)
 {
-- 
1.8.4
Message 1 of 1 in “pack-objects: Limit visibility of 'indexed_commits' symbols”
  1. 4/5 pack-objects: Limit visibility of 'indexed_commits' symbolsRamsay Jones, Nov 7, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.