[PATCH v4 1/2] win32: close handles of threads that have been joined
- From
- Seija Kijin via GitGitGadget <gitgitgadget@gmail.com>
- Date
- Dec 20, 2022, 20:04 UTC
- Message-ID
- <526ef7cc339e2832b71715869f08b32d8454d8a2.1671566641.git.gitgitgadget@gmail.com>
- In-Reply-To
- <pull.1406.v4.git.git.1671566641.gitgitgadget@gmail.com>
From: Seija Kijin <doremylover123@gmail.com>
After joining threads, the handle to the original thread should be closed as it no longer needs to be open.
Signed-off-by: Seija Kijin <doremylover123@gmail.com> --- compat/win32/pthread.c | 5 +++++ 1 file changed, 5 insertions(+)
diff --git a/compat/win32/pthread.c b/compat/win32/pthread.c index 2e7eead42cb..89e89c3fe00 100644 --- a/compat/win32/pthread.c +++ b/compat/win32/pthread.c @@ -42,10 +42,15 @@ int win32_pthread_join(pthread_t *thread, void **value_ptr) case WAIT_OBJECT_0: if (value_ptr) *value_ptr = thread->arg; + /* detach the thread once the join succeeds */ + CloseHandle(thread->handle); return 0; case WAIT_ABANDONED: + /* either thread is not joinable or another thread is + * waiting on this, so do not detatch */ return EINVAL; default: + /* the function failed, so do not detach */ return err_win_to_posix(GetLastError()); } }
-- gitgitgadget