Re: [PATCH 10/15] fetch --tags: fetch tags *in addition to* other stuff
- From
Michael Haggerty <mhagger@alum.mit.edu>
- Date
- Oct 26, 2013, 05:10 UTC
- Message-ID
- <526B4EB7.7020004@alum.mit.edu>
- In-Reply-To
- <xmqqob6emlxu.fsf@gitster.dls.corp.google.com>
On 10/24/2013 10:51 PM, Junio C Hamano wrote:
Show 26 quoted lines
> Michael Haggerty <mhagger@alum.mit.edu> writes: >> diff --git a/Documentation/fetch-options.txt b/Documentation/fetch-options.txt >> index ba1fe49..0e6d2ac 100644 >> --- a/Documentation/fetch-options.txt >> +++ b/Documentation/fetch-options.txt >> @@ -61,11 +61,9 @@ endif::git-pull[] >> ifndef::git-pull[] >> -t:: >> --tags:: >> - This is a short-hand for giving `refs/tags/*:refs/tags/*` >> - refspec from the command line, to ask all tags to be fetched >> - and stored locally. Because this acts as an explicit >> - refspec, the default refspecs (configured with the >> - remote.$name.fetch variable) are overridden and not used. >> + This is a short-hand requesting that all tags be fetched from >> + the remote in addition to whatever else is being fetched. It >> + is similar to using the refspec `refs/tags/*:refs/tags/*`. > > This is no longer a short-hand, is it? There is no other way to ask > "fetch the usual stuff, and then refs/tags/*:refs/tags/* as well". > > It should be sufficient for me to locally do: > > s/This is a short-hand requesting/Request/; > > I think.
Yes, that's better.
Show 12 quoted lines
>> diff --git a/git-pull.sh b/git-pull.sh
>> index b946fd9..dac7e1c 100755
>> --- a/git-pull.sh
>> +++ b/git-pull.sh
>> @@ -172,7 +172,7 @@ error_on_no_merge_candidates () {
>> do
>> case "$opt" in
>> -t|--t|--ta|--tag|--tags)
>> - echo "Fetching tags only, you probably meant:"
>> + echo "It doesn't make sense to pull tags; you probably meant:"
>
> s/pull tags/pull all tags/; perhaps?Yes, that's also an improvement.
Thanks, Michael
-- Michael Haggerty mhagger@alum.mit.edu http://softwareswirl.blogspot.com/