[PATCH] path-utils: Rename mingw_path function to print_path
- From
Sebastian Schuberth <sschuberth@gmail.com>
- Date
- Oct 10, 2013, 20:49 UTC
- Message-ID
- <525712E7.2010608@gmail.com>
mingw_path was introduced in abd4284 to output a mangled path as it is passed as an argument to main(). But the name is misleading because mangling does not come from MinGW, but from MSYS [1]. As abd4284 does not introduce any MSYS or MinGW specific code but just prints out argv[2] as it is passed to main(), give the function the more generic and less confusing name "print_path".
[1] http://www.mingw.org/wiki/Posix_path_conversion
Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com> --- t/t0060-path-utils.sh | 4 ++-- test-path-utils.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/t/t0060-path-utils.sh b/t/t0060-path-utils.sh index 3a48de2..2bd5e32 100755 --- a/t/t0060-path-utils.sh +++ b/t/t0060-path-utils.sh @@ -8,13 +8,13 @@ test_description='Test various path utilities' . ./test-lib.sh norm_path() { - expected=$(test-path-utils mingw_path "$2") + expected=$(test-path-utils print_path "$2") test_expect_success $3 "normalize path: $1 => $2" \ "test \"\$(test-path-utils normalize_path_copy '$1')\" = '$expected'" } relative_path() { - expected=$(test-path-utils mingw_path "$3") + expected=$(test-path-utils print_path "$3") test_expect_success $4 "relative path: $1 $2 => $3" \ "test \"\$(test-path-utils relative_path '$1' '$2')\" = '$expected'" } diff --git a/test-path-utils.c b/test-path-utils.c index bb975e4..3dd3744 100644 --- a/test-path-utils.c +++ b/test-path-utils.c @@ -116,7 +116,7 @@ int main(int argc, char **argv) return 0; } - if (argc == 3 && !strcmp(argv[1], "mingw_path")) { + if (argc == 3 && !strcmp(argv[1], "print_path")) { puts(argv[2]); return 0; }
-- 1.8.4.msysgit.0