Re: [PATCH] git-prompt.sh: show the upstream abbrev name

From: Julien Carsique <julien.carsique@gmail.com>
Date: Oct 10, 2013, 14:43 UTC
Message-ID: <5256BD0A.30706@gmail.com>
In-Reply-To: <20131010135813.GF19704@goldbirke>

On 10/10/2013 15:58, SZEDER Gábor wrote:

Show 15 quoted lines

> Hi,
>
> On Thu, Oct 10, 2013 at 03:32:13PM +0200, Julien Carsique wrote:
>> @@ -204,6 +206,9 @@ __git_ps1_show_upstream ()
>>  		*)	    # diverged from upstream
>>  			p=" u+${count#*	}-${count%	*}" ;;
>>  		esac
>> +		if [[ -n "$count" && -n "$name" ]]; then
>> +			p+=" $(git rev-parse --abbrev-ref "$upstream" 2>/dev/null)"
> The '+=' operator is not supported in all Bash versions we care about.
> Please write this as p="$p $(...)".
>
> Thanks,
> Gábor
>

Hi,

It's fixed.

Note '+=' was already used line 114:

            svn_url_pattern+="\\|$value"

Thank you for the review,