[PATCH 3/6] wrapper.c: Fix a sparse warning

From: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Date: Oct 6, 2013, 20:50 UTC
Message-ID: <5251CCF8.3070207@ramsay1.demon.co.uk>

When the NO_MKSTEMPS build variable is not set, sparse issues an "'gitmkstemps' was not declared. Should it be static?" warning. The 'gitmkstemps' function definition is only required when the NO_MKSTEMPS variable is set. In order to suppress the warning, use a preprocessor conditional to include the definition only when needed.

Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
---
 wrapper.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/wrapper.c b/wrapper.c
index f92b147..9a6aaaf 100644
--- a/wrapper.c
+++ b/wrapper.c
@@ -360,10 +360,12 @@ int git_mkstemp_mode(char *pattern, int mode)
 	return git_mkstemps_mode(pattern, 0, mode);
 }
 
+#ifdef NO_MKSTEMPS
 int gitmkstemps(char *pattern, int suffix_len)
 {
 	return git_mkstemps_mode(pattern, suffix_len, 0600);
 }
+#endif
 
 int xmkstemp_mode(char *template, int mode)
 {

-- 
1.8.4