Re: ds/sparse-checkout-requires-per-worktree-config (Was: Re: What's cooking in git.git (Feb 2022, #04; Tue, 15))

From: Derrick Stolee <derrickstolee@github.com>
Date: Feb 16, 2022, 13:54 UTC
Message-ID: <51efdb1e-00f1-e4c0-97df-478cc5982b49@github.com>
In-Reply-To: <CABPp-BHxg+KE7W0jLfHC+DfjRyNoigv4qSEgJyehnUZNLUzZCg@mail.gmail.com>

On 2/16/2022 12:06 AM, Elijah Newren wrote:

Show 21 quoted lines

> On Tue, Feb 15, 2022 at 12:01 PM Junio C Hamano <gitster@pobox.com> wrote:
>>
>> * ds/sparse-checkout-requires-per-worktree-config (2022-02-08) 6 commits
>>  - config: make git_configset_get_string_tmp() private
>>  - worktree: copy sparse-checkout patterns and config on add
>>  - sparse-checkout: set worktree-config correctly
>>  - config: add repo_config_set_worktree_gently()
>>  - worktree: create init_worktree_config()
>>  - Documentation: add extensions.worktreeConfig details
>>
>>  "git sparse-checkout" wants to work with per-worktree configration,
>>  but did not work well in a worktree attached to a bare repository.
>>
>>  Will merge to 'next'?
>>  cf. <20220204081336.3194538-1-newren@gmail.com>
>>  cf. <CAPig+cRrRxuTeByhKkLs_KDaWY8-r4+jrwT83A-r+sBQsmebMw@mail.gmail.com>
>>  source: <pull.1101.v6.git.1644269583.gitgitgadget@gmail.com>
> 
> With v6, Eric seems to also be happy with the series (cf.
> <CAPig+cQTRGuuspz2g5LZr4Oh8bQCr4FUDV0tirs+ZPwhtAaJVw@mail.gmail.com>).
> So, I think it's ready to merge down.

I agree. Thanks for the close looks at this.

I think I will send a forward fix that attempts to clear up the "worktree" versus "working tree" changes across all of git-worktree.txt and related docs, now that Eric corrected my interpretation of his comments [1].

Thanks, -Stolee

[1] https://lore.kernel.org/git/CAPig+cR+n=LQg5AJQgGQXuYStN90-jExWnE45sS1EXo+O8dQgQ@mail.gmail.com/