git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 1/3] gitweb: Fix a typo in a comment

From
Jakub Narębski <jnareb@gmail.com>
Date
Oct 14, 2016, 17:34 UTC
Message-ID
<51eb6aba-9cd2-47f4-a26e-6dbbabdaa282@gmail.com>
In-Reply-To
<20161006091135.29590-2-avarab@gmail.com>
W dniu 06.10.2016 o 11:11, Ævar Arnfjörð Bjarmason napisał:
Show 7 quoted lines
> Change a typo'd MIME type in a comment. The Content-Type is
> application/xhtml+xml, not application/xhtm+xml.
> 
> Fixes up code originally added in 53c4031 ("gitweb: Strip
> non-printable characters from syntax highlighter output", 2011-09-16).
> 
> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>

Good. Thanks for taking care of this. For what is worth for such a trivial patch:

Acked-by: Jakub Narębski <jnareb@gmail.com>
Show 18 quoted lines
> ---
>  gitweb/gitweb.perl | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
> index 44094f4..cba7405 100755
> --- a/gitweb/gitweb.perl
> +++ b/gitweb/gitweb.perl
> @@ -1616,7 +1616,7 @@ sub esc_path {
>  	return $str;
>  }
>  
> -# Sanitize for use in XHTML + application/xml+xhtm (valid XML 1.0)
> +# Sanitize for use in XHTML + application/xml+xhtml (valid XML 1.0)
>  sub sanitize {
>  	my $str = shift;
>  
> 
Previous: Ævar Arnfjörð BjarmasonNext: Ævar Arnfjörð Bjarmason
Message 3 of 16 in “gitweb: Be smarter about linking to SHA1s in log messages”
  1. 0/3 gitweb: Be smarter about linking to SHA1s in log messagesÆvar Arnfjörð Bjarmason, Oct 6, 2016
  2. 1/3 gitweb: Fix a typo in a commentÆvar Arnfjörð Bjarmason, Oct 6, 2016
  3. Jakub NarębskiOct 14, 2016
  4. 3/3 gitweb: Link to "git describe"'d commits in log messagesÆvar Arnfjörð Bjarmason, Oct 6, 2016
  5. Junio C HamanoOct 6, 2016
  6. Ævar Arnfjörð BjarmasonOct 9, 2016
  7. Ævar Arnfjörð BjarmasonOct 14, 2016
  8. Junio C HamanoOct 14, 2016
  9. Jakub NarębskiOct 14, 2016
  10. 2/3 gitweb: Link to 7-char+ SHA1s, not only 8-char+Ævar Arnfjörð Bjarmason, Oct 6, 2016
  11. Junio C HamanoOct 6, 2016
  12. Jakub NarębskiOct 14, 2016
  13. Junio C HamanoOct 14, 2016
  14. Ævar Arnfjörð BjarmasonOct 15, 2016
  15. Junio C HamanoOct 17, 2016
  16. Ævar Arnfjörð BjarmasonOct 17, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.