git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Possible bug in git-rebase man page

From
PWPhillip Wood <phillip.wood123@gmail.com>
Date
Apr 6, 2023, 09:49 UTC
Message-ID
<51aca4bd-0f2b-0689-4b51-260349cc4151@gmail.com>
In-Reply-To
<db535468-c991-df18-61bd-ec312fdb5ca0@haller-berlin.de>
Hi Stefan
On 05/04/2023 18:36, Stefan Haller wrote:
Show 10 quoted lines
> The git-rebase documentation has an example for a git-rebase-todo file
> when --rebase-merges is used; one of the lines in that file is
> 
>    reset refactor-button # Use the Button class for all buttons
> 
>  From reading the code that parses the file, this doesn't seem to be a
> valid line; as far as I can see, comments are not supported for reset or
> label. The label is the entire rest of the line after the command.
> 
> Just wanted to confirm that I'm not missing anything.

You're right that comments are not supported for labels, but for the reset command do_reset() ignores everything after the label so it does effectively support comments. I've got some patches to support comments on other commands which I'll hopefully submit before too long.

Best Wishes
Phillip
> -Stefan
>
Previous: Stefan HallerNext: Stefan Haller
Message 2 of 6 in “Possible bug in git-rebase man page”
  1. Stefan HallerApr 5, 2023
  2. Phillip WoodApr 6, 2023
  3. Stefan HallerApr 6, 2023
  4. Phillip WoodApr 6, 2023
  5. Stefan HallerApr 7, 2023
  6. Phillip WoodApr 11, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.