Re: [PATCH 2/4] log, format-patch: accept short parameter 'q' for quiet
- From
René Scharfe <l.s.r@web.de>
- Date
- Jul 29, 2013, 22:05 UTC
- Message-ID
- <51F6E71A.8050109@web.de>
- In-Reply-To
- <1375127398-31904-3-git-send-email-stefanbeller@googlemail.com>
Am 29.07.2013 21:49, schrieb Stefan Beller:
Show 15 quoted lines
> Signed-off-by: Stefan Beller <stefanbeller@googlemail.com>
> ---
> builtin/log.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/builtin/log.c b/builtin/log.c
> index 9b6c910..5cb968b 100644
> --- a/builtin/log.c
> +++ b/builtin/log.c
> @@ -121,7 +121,7 @@ static void cmd_log_init_finish(int argc, const char **argv, const char *prefix,
> static struct line_opt_callback_data line_cb = {NULL, NULL, STRING_LIST_INIT_DUP};
>
> const struct option builtin_log_options[] = {
> - OPT_BOOL(0, "quiet", &quiet, N_("suppress diff output")),
> + OPT_BOOL('q', "quiet", &quiet, N_("suppress diff output")),You can shorten it using OPT__QUIET. But that macro should be converted to OPT_BOOL first, in turn. Unless --verbose, for which it sometimes makes sense to print ever more output the more often it is specified, I wouldn't expect there to be a command with different levels of quietness, but didn't check.
Show 13 quoted lines
> OPT_BOOL(0, "source", &source, N_("show source")),
> OPT_BOOL(0, "use-mailmap", &mailmap, N_("Use mail map file")),
> { OPTION_CALLBACK, 0, "decorate", NULL, NULL, N_("decorate options"),
> @@ -1210,7 +1210,7 @@ int cmd_format_patch(int argc, const char **argv, const char *prefix)
> PARSE_OPT_OPTARG, thread_callback },
> OPT_STRING(0, "signature", &signature, N_("signature"),
> N_("add a signature")),
> - OPT_BOOL(0, "quiet", &quiet,
> + OPT_BOOL('q', "quiet", &quiet,
> N_("don't print the patch filenames")),
> OPT_END()
> };
>