git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] do_one_ref(): save and restore value of current_ref

From
Michael Haggerty <mhagger@alum.mit.edu>
Date
Jul 24, 2013, 14:35 UTC
Message-ID
<51EFE62C.4070003@alum.mit.edu>
In-Reply-To
<7vppueuyw4.fsf@alter.siamese.dyndns.org>
On 07/19/2013 12:34 PM, Junio C Hamano wrote:
Show 9 quoted lines
> Michael Haggerty <mhagger@alum.mit.edu> writes:
> 
>> I sent the patch shortly before leaving for a trip so I didn't have time
>> to make it as complete as I would have liked.  But given that the
>> problem was already in master, and the fix is pretty simple, I wanted to
>> send the fix right away.  When I have some time I can fix it up better,
> 
> That is very much appreciated.  How would you describe this fix in a
> two-to-three line paragraph in Release Notes?
How about:
    Fix a NULL-pointer dereference during nested iterations over
    references (for example, when replace references are being used).

Unfortunately I don't have time now to audit the code more carefully to figure out what other circumstances might have triggered the bug.

Hope that helps, Michael

-- 
Michael Haggerty
mhagger@alum.mit.edu
http://softwareswirl.blogspot.com/
Previous: Junio C Hamano
Message 8 of 8 in “Segfault in `git describe`”
  1. Mantas MikulėnasJul 13, 2013
  2. Michael HaggertyJul 15, 2013
  3. Mantas MikulėnasJul 15, 2013
  4. do_one_ref(): save and restore value of current_refMichael Haggerty, Jul 15, 2013
  5. Junio C HamanoJul 18, 2013
  6. Michael HaggertyJul 19, 2013
  7. Junio C HamanoJul 19, 2013
  8. Michael HaggertyJul 24, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.