git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v4 0/6] submodule: drop the top-level requirement

From
Jens Lehmann <jens.lehmann@web.de>
Date
Jun 17, 2013, 20:41 UTC
Message-ID
<51BF748F.7070708@web.de>
In-Reply-To
<cover.1371391740.git.john@keeping.me.uk>
Am 16.06.2013 16:18, schrieb John Keeping:
Show 20 quoted lines
> Changes since v3:
> 
> * There are four new patches, three of which are style fixes for
>   existing tests and one fixes an existing error message to return a
>   more accurate path when recursing.
> 
> * You now cannot run "git submodule add <relative URL>" from a
>   subdirectory.  Because the interpretation of the URL changes depending
>   on whether or not remote.origin.url is configured, I have decided to
>   just ban this for now.  If someone comes up with a sensible way to
>   handle this then we can lift this restriction later.
> 
> * The "path" variable exported in "submodule foreach" now uses the
>   relative path and matches the "sm_path" variable.
> 
> * I audited the code again and fixed a few more cases that weren't
>   printing relative paths (notably "submodule init" and "submodule
>   foreach").
> 
> * More tests.
Thanks for working on this! This series is looking good to me.
Show 20 quoted lines
> John Keeping (6):
>   t7401: make indentation consistent
>   t7403: modernize style
>   t7403: add missing && chaining
>   submodule: show full path in error message
>   rev-parse: add --prefix option
>   submodule: drop the top-level requirement
> 
>  Documentation/git-rev-parse.txt |  16 ++
>  builtin/rev-parse.c             |  24 ++-
>  git-submodule.sh                | 135 ++++++++++----
>  t/t1513-rev-parse-prefix.sh     |  96 ++++++++++
>  t/t7400-submodule-basic.sh      |  80 +++++++++
>  t/t7401-submodule-summary.sh    | 116 +++++++-----
>  t/t7403-submodule-sync.sh       | 388 ++++++++++++++++++++++++++--------------
>  t/t7406-submodule-update.sh     |  15 ++
>  t/t7407-submodule-foreach.sh    |  16 ++
>  9 files changed, 673 insertions(+), 213 deletions(-)
>  create mode 100755 t/t1513-rev-parse-prefix.sh
> 
Previous: John Keeping
Message 8 of 8 in “submodule: drop the top-level requirement”
  1. 0/6 submodule: drop the top-level requirementJohn Keeping, Jun 16, 2013
  2. 1/6 t7401: make indentation consistentJohn Keeping, Jun 16, 2013
  3. 2/6 t7403: modernize styleJohn Keeping, Jun 16, 2013
  4. 3/6 t7403: add missing && chainingJohn Keeping, Jun 16, 2013
  5. 4/6 submodule: show full path in error messageJohn Keeping, Jun 16, 2013
  6. 5/6 rev-parse: add --prefix optionJohn Keeping, Jun 16, 2013
  7. 6/6 submodule: drop the top-level requirementJohn Keeping, Jun 16, 2013
  8. Jens LehmannJun 17, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.