Re: What's cooking in git.git (May 2013, #09; Wed, 29)

From: Jens Lehmann <jens.lehmann@web.de>
Date: May 30, 2013, 19:23 UTC
Message-ID: <51A7A73C.6070103@web.de>
In-Reply-To: <7va9ndqqyf.fsf@alter.siamese.dyndns.org>

Am 30.05.2013 01:58, schrieb Junio C Hamano:

Show 9 quoted lines

> * jk/submodule-subdirectory-ok (2013-04-24) 3 commits
>   (merged to 'next' on 2013-04-24 at 6306b29)
>  + submodule: fix quoting in relative_path()
>   (merged to 'next' on 2013-04-22 at f211e25)
>  + submodule: drop the top-level requirement
>  + rev-parse: add --prefix option
> 
>  Allow various subcommands of "git submodule" to be run not from the
>  top of the working tree of the superproject.

The summary and status commands are looking good in this version (they are now showing the submodule directory paths relative to the current directory). Apart from that my other remarks from gmane $221575 still seem to apply. And this series has only tests for status, summary and add (and that just with an absolute URL), I'd rather like to see a test for each submodule command (and a relative add to) to document the desired behavior.

But I'm not sure if it's better to have another iteration of this series or to address the open issues a follow-up series. Having status, summary and add - at least with absolute URLs - lose the toplevel requirement is already a huge improvement IMO. Opinions?