git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] http: fix an unused variable warning for 'curl_no_proxy'

From
Ramsay Jones <ramsay@ramsayjones.plus.com>
Date
Mar 14, 2018, 21:56 UTC
Message-ID
<517c4210-c381-899e-b13a-00f8e4caba74@ramsayjones.plus.com>
Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
---
Hi Junio,

I happened to be building git on an _old_ laptop earlier this evening and gcc complained, thus:

      CC http.o
  http.c:77:20: warning: ‘curl_no_proxy’ defined but not used [-Wunused-variable]
   static const char *curl_no_proxy;
                      ^
The version of libcurl installed was 0x070f04. So, while it was fresh in my
mind, I applied and tested this patch.

ATB, Ramsay Jones

 http.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/http.c b/http.c
index 8c11156ae..a5bd5d62c 100644
--- a/http.c
+++ b/http.c
@@ -69,6 +69,9 @@ static const char *ssl_key;
 #if LIBCURL_VERSION_NUM >= 0x070908
 static const char *ssl_capath;
 #endif
+#if LIBCURL_VERSION_NUM >= 0x071304
+static const char *curl_no_proxy;
+#endif
 #if LIBCURL_VERSION_NUM >= 0x072c00
 static const char *ssl_pinnedkey;
 #endif
@@ -77,7 +80,6 @@ static long curl_low_speed_limit = -1;
 static long curl_low_speed_time = -1;
 static int curl_ftp_no_epsv;
 static const char *curl_http_proxy;
-static const char *curl_no_proxy;
 static const char *http_proxy_authmethod;
 static struct {
 	const char *name;
-- 
2.16.0
Next: Jonathan Nieder
Message 1 of 5 in “http: fix an unused variable warning for 'curl_no_proxy'”
  1. http: fix an unused variable warning for 'curl_no_proxy'Ramsay Jones, Mar 14, 2018
  2. Jonathan NiederMar 14, 2018
  3. Jeff KingMar 14, 2018
  4. Ramsay JonesMar 14, 2018
  5. Jeff KingMar 15, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.