Re: [PATCH 2/2] doc/http-backend: give some lighttpd config examples

From: Jakub Narębski <jnareb@gmail.com>
Date: Apr 11, 2013, 16:47 UTC
Message-ID: <5166E935.2080206@gmail.com>
In-Reply-To: <20130411033613.GB14551@sigill.intra.peff.net>

W dniu 11.04.2013 05:36, Jeff King napisał:

Show 6 quoted lines

> +Note that unlike the similar setup with Apache, we can easily match the
> +query string for receive-pack, catching the initial request from the
> +client. This means that the server administrator does not have to worry
> +about configuring `http.receivepack` for the repositories (the default
> +value, which enables it only in the case of authentication, is
> +sufficient).

Perhaps it would be worth including for Apache2 beside basic setup that requires http.receivepack set to true, also one like for LigHTTPd, i.e.

  RewriteCond %{QUERY_STRING} =service=git-receive-pack [OR]
  RewriteCond %{REQUEST_URI} /git-receive-pack$
  RewriteRule (.*) $1 [E=AUTHREQUIRED:yes]

  <Location /gitweb/>
      Order Deny,Allow
      Deny from env=AUTHREQUIRED

      AuthType Basic
      AuthName "Git Access"
      Require group committers

      Satisfy Any
  <Location>

And perhaps also adding it as test...

-- 
Jakub Narębski