Re: [PATCH] git-imap-send.txt: remove the use of sslverify=false in GMail example
- From
Barbu Paul - Gheorghe <barbu.paul.gheorghe@gmail.com>
- Date
- Apr 11, 2013, 13:36 UTC
- Message-ID
- <5166BC41.5020202@gmail.com>
- In-Reply-To
- <7vmwt6mdjg.fsf@alter.siamese.dyndns.org>
On 04/10/2013 09:44 PM, Junio C Hamano wrote:
> Thanks.
My pleasure.
> While removing that item from the configuration is a good thing to > do in the post 1.8.2.1 era, the reason why it is does not have much > to do with "GMail is SSL capable".
Should I change the commit message in order to avoid confusion among devs that read it?
> The configuration item is not about "Do we connect over SSL when > talking to this host?", but is about "When we use SSL with this > host, do we verify the certificate it gave us?".
If I change it, how should it sound? It could be:
Since GMail's certificates can be sslverify-ed there is no need to set sslverify to false, the example using it may confuse readers that it's needed since it's also used in the previous example configurations, too.
Have a nice day!
-- Barbu Paul - Gheorghe Common sense is not so common - Voltaire Visit My GitHub profile to see my open-source projects - https://github.com/paullik