Re: [PATCH v2 0/4] remote-helpers: trivial test fixes

From: Torsten Bögershausen <tboegi@web.de>
Date: Apr 6, 2013, 17:09 UTC
Message-ID: <516056AE.9060304@web.de>
In-Reply-To: <51605546.3080503@web.de>

On 06.04.13 19:03, Torsten Bögershausen wrote:

Show 21 quoted lines

> On 04.04.13 17:36, Felipe Contreras wrote:
>> Hi,
>>
>> A reroll, now we do some checks, just avoid test-lint-duplicates, and fix the
>> outsanding shell portability issue. The rest is the same.
>>
>> Felipe Contreras (4):
>>   remote-bzr: avoid echo -n
>>   remote-helpers: fix the run of all tests
>>   remote-bzr: remove stale check code for tests
>>   remote-hg: fix hg-git test-case
>>
>>  contrib/remote-helpers/Makefile          |  1 +
>>  contrib/remote-helpers/test-bzr.sh       | 16 +---------------
>>  contrib/remote-helpers/test-hg-hg-git.sh |  1 -
>>  3 files changed, 2 insertions(+), 16 deletions(-)
>>
> Sorry being late, now I installed bzr and hg on one of my machines 
> 
> One defect found: "\s" is not portable on all grep versions
> A "*" is not a "basic regular expression", so we need to use egrep

Sorry for confusion: A "*" is a basic regular expression, but not the "+" "+" is an extended regular expression, which is understood by some grep versions (gnu ?).

Felipe: Should I send a patch, or wait for a re-roll?