[PATCH 4/8] dir.c: git-status --ignored: don't list empty directories as ignored
- From
Karsten Blees <karsten.blees@gmail.com>
- Date
- Mar 18, 2013, 20:28 UTC
- Message-ID
- <51477901.9020804@gmail.com>
- In-Reply-To
- <514775FA.9080304@gmail.com>
'git-status --ignored' lists empty untracked directories as ignored, even though they don't have any ignored files.
When checking if a directory is already listed as untracked (i.e. shouldn't be listed as ignored as well), don't assume that the dirctory has only ignored files if it doesn't have untracked files, as the directory may be empty.
Signed-off-by: Karsten Blees <blees@dcon.de> --- dir.c | 17 ++++++++--------- t/t7061-wtstatus-ignore.sh | 26 ++++++++++++++++++++++++-- 2 files changed, 32 insertions(+), 11 deletions(-)
diff --git a/dir.c b/dir.c index fd1f088..64457db 100644 --- a/dir.c +++ b/dir.c @@ -1071,17 +1071,16 @@ static enum directory_treatment treat_directory(struct dir_struct *dir, /* * We are looking for ignored files and our directory is not ignored, - * check if it contains only ignored files + * check if it contains untracked files (i.e. is listed as untracked) */ if ((dir->flags & DIR_SHOW_IGNORED) && !exclude) { - int ignored; - dir->flags &= ~DIR_SHOW_IGNORED; - dir->flags |= DIR_HIDE_EMPTY_DIRECTORIES; - ignored = read_directory_recursive(dir, dirname, len, 1, simplify); - dir->flags &= ~DIR_HIDE_EMPTY_DIRECTORIES; - dir->flags |= DIR_SHOW_IGNORED; - - return ignored ? ignore_directory : show_directory; + int untracked; + dir->flags &= ~(DIR_SHOW_IGNORED|DIR_SHOW_OTHER_DIRECTORIES); + untracked = read_directory_recursive(dir, dirname, len, 1, simplify); + dir->flags |= DIR_SHOW_IGNORED|DIR_SHOW_OTHER_DIRECTORIES; + + if (untracked) + return ignore_directory; } if (!(dir->flags & DIR_SHOW_IGNORED) && !(dir->flags & DIR_HIDE_EMPTY_DIRECTORIES)) diff --git a/t/t7061-wtstatus-ignore.sh b/t/t7061-wtstatus-ignore.sh index 28b7d95..6171a49 100755 --- a/t/t7061-wtstatus-ignore.sh +++ b/t/t7061-wtstatus-ignore.sh @@ -64,13 +64,35 @@ cat >expected <<\EOF ?? .gitignore ?? actual ?? expected -!! untracked-ignored/ EOF -test_expect_success 'status untracked directory with ignored files with --ignore' ' +test_expect_success 'status empty untracked directory with --ignore' ' rm -rf ignored && mkdir untracked-ignored && mkdir untracked-ignored/test && + git status --porcelain --ignored >actual && + test_cmp expected actual +' + +cat >expected <<\EOF +?? .gitignore +?? actual +?? expected +EOF + +test_expect_success 'status empty untracked directory with --ignore -u' ' + git status --porcelain --ignored -u >actual && + test_cmp expected actual +' + +cat >expected <<\EOF +?? .gitignore +?? actual +?? expected +!! untracked-ignored/ +EOF + +test_expect_success 'status untracked directory with ignored files with --ignore' ' : >untracked-ignored/ignored && : >untracked-ignored/test/ignored && git status --porcelain --ignored >actual &&
-- 1.8.1.2.8021.g7e51819