Re: Re: [PATCH v2 4/4] teach config parsing to read from strbuf

> On Thu, Mar 14, 2013 at 03:10:46AM -0400, Jeff King wrote:
>
> > I looked into this a little. The first sticking point is that
> > git_config_with_options needs to support the alternate source. Here's a
> > sketch of what I think the solution should look like, on top of your
> > patches.
>
> Here it is again, with two changes:
>
>   1. Rather than handling the blob lookup inline in
>      git_config_with_options, it adds direct functions for reading
>      config from blob sha1s and blob references. I think this should
>      make it easier to reuse when you are trying to read .gitmodules
>      from C code.
>
>   2. It adds some basic tests.
>
> I'll leave it here for tonight. The next step would be to rebase it on
> your modified series (in particular, I think git_config_from_strbuf
> should become git_config_from_buf, which will impact this).
>
> Feel free to use, pick apart, rewrite, or discard as you see fit for
> your series.