git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] gitk: Add user-configurable branch bg color

From
MBManuel Bua <manuel.bua@gmail.com>
Date
Mar 17, 2013, 12:46 UTC
Message-ID
<5145BB41.3020406@gmail.com>
In-Reply-To
<CAJDDKr5XqX3dKLEiOAo7VeaofN37Q8aAN=GyMVf5-bGiiv9FDw@mail.gmail.com>
On 03/17/2013 03:57 AM, David Aguilar wrote:
Show 12 quoted lines
>
> > In some cases, the default branch background color (green) isn't
> > an optimal choice, thus it can be difficult to read.
>
> I'm just curious -- is it "difficult to read" because gitk does not 
> specify a foreground color, thus causing it to pickup a system default 
> (which can vary), or is it for a different reason?
>
> If this is the reason then I wonder whether gitk should explicitly set 
> a foreground color. Apologies if it already works that way -- I just 
> wanted to better understand the motivation behind this patch.
>

Yes, having gitk to specify a foreground color instead would probably solve it too: i can remember the branch rectangles were a lot more readable in the past, but this could probably be due to me using a dark system theme at the time.

For example, in my case it would look a lot more readable if the text was "white on green" instead of "black on green", that could be even hardcoded as it was with the "green" color, but the reason behind the choice to let the user customize it is that i think it is better to honour the user system colors giving the means to adjust it to match his actual system configuration, rather than overriding it.

Regards, Manuel

Previous: Manuel Bua
Message 2 of 2 in “gitk: Add user-configurable branch bg color”
  1. gitk: Add user-configurable branch bg colorManuel Bua, Mar 16, 2013
  2. Manuel BuaMar 17, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.