git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC with a proof of concept PATCH] Add Bonsai-like query options to gitk

From
Elijah Newren <newren@gmail.com>
Date
Mar 23, 2009, 17:56 UTC
Message-ID
<51419b2c0903231056h4eef8d6cgef42f38bb21db1d5@mail.gmail.com>
In-Reply-To
<51419b2c0903231054g621787b6i8537b8e0d5bf121d@mail.gmail.com>
(Sorry, resending my own email since I accidentally left of the cc's.)
On Mon, Mar 23, 2009 at 4:07 AM, Paul Mackerras <paulus@samba.org> wrote:
Show 7 quoted lines
> Elijah Newren <newren@gmail.com> writes:
>
>> (If you like screenshots, I've got some before & after ones up at
>> http://www.gnome.org/~newren/temp/gitk/gitk-edit-view.html, but
>> remember that this is just a proof of concept and call for comments.)
>
> Looks reasonable... have you developed the patch any further?

Yes, I have. There was a cosmetic tweak or two, but the main change was fixing the view remembering stuff that I noted I broke in the original patch. I've also showed this modified dialog in two different git presentations, to dozens of new and potential users of git, and it seems to have been well received[1]. I'll send a follow-up patch shortly (I'd copy it inline, but I'm afraid gmail will screw it up).

Elijah

[1] For one of the two groups, a lack of a Bonsai replacement actually derailed their conversion to svn about a year ago. This group was very interested in git after my presentation and seemed satisfied with gitk (with my proposed changes) as a replacement for Bonsai. There was one minor question that did come up each time -- one person in each presentation asked why it is that when you specify --author=smith (at the command line or via the equivalent box in the gui), you also see commits authored by e.g. "jones" in gitk; however, once I mentioned the different colored dots in gitk and the fact that it's showing the commits that the patches are relative to, there was no more issue and everyone was happy. I'm guessing it'd be slightly more intuitive to them to have gitk filter out these parent commits from the graph unless they also meet the search criteria, but it's a pretty minor issue.

Previous: newren@gmail.com
Message 4 of 4 in “Add Bonsai-like query options to gitk”
  1. Add Bonsai-like query options to gitknewren@gmail.com, Mar 9, 2009
  2. Paul MackerrasMar 23, 2009
  3. gitk: Make more options easily accessible from Edit View dialognewren@gmail.com, Mar 23, 2009
  4. Elijah NewrenMar 23, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.