Re: [PATCH 2/2] push: --follow-tag

From: Michael Haggerty <mhagger@alum.mit.edu>
Date: Mar 5, 2013, 11:49 UTC
Message-ID: <5135DBE5.6080909@alum.mit.edu>
In-Reply-To: <20130305082204.GB13552@sigill.intra.peff.net>

On 03/05/2013 09:22 AM, Jeff King wrote:

Show 18 quoted lines

> On Mon, Mar 04, 2013 at 04:54:39PM -0800, Junio C Hamano wrote:
> [...]
> This will find anything under refs/tags, including annotated and
> non-annotated tags. I wonder if it is worth making a distinction. In
> many workflows, unannotated tags should not be leaked out to public
> repos. But because this feature finds any reachable tags, it will push a
> tag you made a long time ago as a bookmarker on some part of the history
> unrelated to the release you are making now.
> 
> One obvious alternative is only to push annotated tags with this
> feature. That has the downside of not matching fetch's behavior, as well
> as withholding the feature from people whose workflow uses only
> unannotated tags.
> 
> Another alternative would be to change the inclusion rule from
> "reachable" to "points at the tip of something being sent". But then we
> lose the feature that it would backfill any old tags the remote happens
> to be missing.

I have no opinion on this matter, but ISTM that another obvious alternative would be to push tags that point at *any* commits that are being sent (not just at the tip), but not those that point to older commits already known to the server. This would reduce the potential for accidental pushes of "distant" tags.

Michael

-- 
Michael Haggerty
mhagger@alum.mit.edu
http://softwareswirl.blogspot.com/