Re: patch for fix build git on Haiku

From: Andreas Färber <andreas.faerber@web.de>
Date: Feb 24, 2013, 09:36 UTC
Message-ID: <5129DF23.7050206@web.de>
In-Reply-To: <20130223204208.GB3222@elie.Belkin>

Hi,

Am 23.02.2013 21:42, schrieb Jonathan Nieder:

Show 27 quoted lines

> diger wrote:
> 
>> This patch fixes build git on Haiku
> 
> Lovely.  May we have your sign-off?  (See
> Documentation/SubmittingPatches for what this means.)  Does "make
> test" pass?  (Just curious --- it's fine if it doesn't, though in that
> case a list of test failures would be helpful.)
> 
> Thanks,
> Jonathan
> 
> (patch left unsnipped for reference)
> 
>> --- Makefile.orig	2012-10-21 21:32:15.000000000 +0000
>> +++ Makefile
>> @@ -1211,6 +1204,16 @@ ifeq ($(uname_S),HP-UX)
>>  	endif
>>  	GIT_TEST_CMP = cmp
>>  endif
>> +ifeq ($(uname_S),Haiku)
>> +    NO_R_TO_GCC_LINKER = YesPlease
>> +    NO_LIBGEN_H = YesPlease
>> +    NO_MEMMEM = YesPlease
>> +    NO_MKSTEMPS = YesPlease
>> +    NEEDS_LIBICONV = YesPlease
>> +    DEFAULT_EDITOR = nano

Patch looks okay from what I have from my earlier ones in mind, but I believe nano is an Optional Package on Haiku and thus not guaranteed to be installed. CC'ing HaikuPorts.

Regards, Andreas

Show 6 quoted lines

>> +    PTHREAD_LIBS =    -lroot
>> +    NO_CROSS_DIRECTORY_HARDLINKS = YesPlease
>> +endif
>>  ifeq ($(uname_S),Windows)
>>  	GIT_VERSION := $(GIT_VERSION).MSVC
>>  	pathsep = ;