Re: [RFC] test-lib.sh: No POSIXPERM for cygwin

From: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Date: Feb 7, 2013, 18:25 UTC
Message-ID: <5113F1B1.3010102@ramsay1.demon.co.uk>
In-Reply-To: <201301271557.08994.tboegi@web.de>

Torsten Bögershausen wrote:

> t0070 and t1301 fail when running the test suite under cygwin.
> Skip the failing tests by unsetting POSIXPERM.

t1301 does not fail for me. (WIN XP (SP3) on NTFS) [It's so long since I looked, but I'm pretty sure that the failure in t0070 is caused by *git*, not by cygwin not supporting POSIXPERM]

Show 18 quoted lines

> Signed-off-by: Torsten Bögershausen <tboegi@web.de>
> ---
>  t/test-lib.sh | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/t/test-lib.sh b/t/test-lib.sh
> index 1a6c4ab..94b097e 100644
> --- a/t/test-lib.sh
> +++ b/t/test-lib.sh
> @@ -669,7 +669,6 @@ case $(uname -s) in
>  	test_set_prereq SED_STRIPS_CR
>  	;;
>  *CYGWIN*)
> -	test_set_prereq POSIXPERM
>  	test_set_prereq EXECKEEPSPID
>  	test_set_prereq NOT_MINGW
>  	test_set_prereq SED_STRIPS_CR
>

So, I'm not in favour of this, FWIW.

ATB, Ramsay Jones