Re: [PATCH v3 3/3] correct ce_compare_data() in a middle of a merge

From: Torsten Bögershausen <tboegi@web.de>
Date: Jul 12, 2016, 02:23 UTC
Message-ID: <51079140-98c8-ee0c-72d2-af5c348c19fd@web.de>
In-Reply-To: <xmqqinwc7xbb.fsf@gitster.mtv.corp.google.com>

Show 7 quoted lines

>
> How do things look at this point?  This version is what I ended up
> queuing in 'pu', but I took your "Thanks" in $gmane/299120 to only
> mean "Thanks for feeding some ideas to help me move forward", not
> necessarily "Tnanks that looks like the right approach." yet, so
> right now both topics are stalled and waiting for an action from
> you.

Yes, the code looks good to me. And the commit message does explain what is going on.

For my taste, these 3 lines don't explain too much,may be remove them ?
 > The test update was taken from a series by Torsten Bögershausen
 > that attempted to fix this with a different approach (which was a
 > lot more intrusive).
So thanks for your efforts, ack from my side.