Re: [PATCH] advice: omit trailing whitespace
On 2024-03-29 23:57, Junio C Hamano wrote:
Show 12 quoted lines
> Git tools all consistently encourage users to avoid whitespaces at
> the end of line by giving them features like "git diff --check" and
> "git am --whitespace=fix". Make sure that the advice messages we
> give users avoid trailing whitespaces. We shouldn't be wasting
> vertical screen real estate by adding blank lines in advice messages
> that are supposed to be concise hints, but as long as we write such
> blank line in our "hints", we should do it right.
>
> A test that expects the current behaviour of leaving trailing
> whitespaces has been adjusted.
>
> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Looking good to me. Consistency is always good.
Reviewed-by: Dragan Simic <dsimic@manjaro.org>
Show 38 quoted lines
> ---
> advice.c | 3 ++-
> t/t3200-branch.sh | 4 ++--
> 2 files changed, 4 insertions(+), 3 deletions(-)
>
> diff --git c/advice.c w/advice.c
> index d19648b7f8..75111191ad 100644
> --- c/advice.c
> +++ w/advice.c
> @@ -105,8 +105,9 @@ static void vadvise(const char *advice, int
> display_instructions,
>
> for (cp = buf.buf; *cp; cp = np) {
> np = strchrnul(cp, '\n');
> - fprintf(stderr, _("%shint: %.*s%s\n"),
> + fprintf(stderr, _("%shint:%s%.*s%s\n"),
> advise_get_color(ADVICE_COLOR_HINT),
> + (np == cp) ? "" : " ",
> (int)(np - cp), cp,
> advise_get_color(ADVICE_COLOR_RESET));
> if (*np)
> diff --git c/t/t3200-branch.sh w/t/t3200-branch.sh
> index d3bbd00b81..ccfa6a720d 100755
> --- c/t/t3200-branch.sh
> +++ w/t/t3200-branch.sh
> @@ -1154,9 +1154,9 @@ test_expect_success 'avoid ambiguous track and
> advise' '
> hint: tracking ref '\''refs/heads/main'\'':
> hint: ambi1
> hint: ambi2
> - hint: ''
> + hint:
> hint: This is typically a configuration error.
> - hint: ''
> + hint:
> hint: To support setting up tracking branches, ensure that
> hint: different remotes'\'' fetch refspecs map into different
> hint: tracking namespaces.