Re: What's cooking in git.git (Jan 2013, #07; Thu, 17)

From: Michael Haggerty <mhagger@alum.mit.edu>
Date: Jan 18, 2013, 15:08 UTC
Message-ID: <50F96589.4010408@alum.mit.edu>
In-Reply-To: <7vsj5zs5y2.fsf@alter.siamese.dyndns.org>

On 01/18/2013 01:14 AM, Junio C Hamano wrote:

Show 22 quoted lines

> [...]
> * mh/imap-send-shrinkage (2013-01-15) 14 commits
>  - imap-send.c: simplify logic in lf_to_crlf()
>  - imap-send.c: fold struct store into struct imap_store
>  - imap-send.c: remove unused field imap_store::uidvalidity
>  - imap-send.c: use struct imap_store instead of struct store
>  - imap-send.c: remove unused field imap_store::trashnc
>  - imap-send.c: remove namespace fields from struct imap
>  - imap-send.c: remove struct imap argument to parse_imap_list_l()
>  - imap-send.c: inline parse_imap_list() in parse_list()
>  - imap-send.c: remove some unused fields from struct store
>  - imap-send.c: remove struct message
>  - imap-send.c: remove struct store_conf
>  - iamp-send.c: remove unused struct imap_store_conf
>  - imap-send.c: remove struct msg_data
>  - imap-send.c: remove msg_data::flags, which was always zero
> 
>  Remove a lot of unused code from "git imap-send".
> 
>  With a further comment fixup in patch #6, this seems ready for
>  'next'.
>  Expecting a reroll.

I'm confused. It seems like you are referring to the comment improvement suggested by Jonathan Nieder [1] that you have already incorporated [2] into mh/imap-send-shrinkage. If you think there is something that needs rerolling, please explain.

Thanks, Michael

[1] http://permalink.gmane.org/gmane.comp.version-control.git/213672 [2] http://permalink.gmane.org/gmane.comp.version-control.git/213681

-- 
Michael Haggerty
mhagger@alum.mit.edu
http://softwareswirl.blogspot.com/