git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] Allow custom "comment char"

From
Jens Lehmann <jens.lehmann@web.de>
Date
Jan 16, 2013, 21:02 UTC
Message-ID
<50F71563.20406@web.de>
In-Reply-To
<1358363928-16729-1-git-send-email-ralf.thielow@gmail.com>
Am 16.01.2013 20:18, schrieb Ralf Thielow:
Show 26 quoted lines
> From: Junio C Hamano <gitster@pobox.com>
> 
> Some users do want to write a line that begin with a pound sign, #,
> in their commit log message.  Many tracking system recognise
> a token of #<bugid> form, for example.
> 
> The support we offer these use cases is not very friendly to the end
> users.  They have a choice between
> 
>  - Don't do it.  Avoid such a line by rewrapping or indenting; and
> 
>  - Use --cleanup=whitespace but remove all the hint lines we add.
> 
> Give them a way to set a custom comment char, e.g.
> 
>     $ git -c core.commentchar="%" commit
> 
> so that they do not have to do either of the two workarounds.
> 
> Signed-off-by: Junio C Hamano <gitster@pobox.com>
> Signed-off-by: Ralf Thielow <ralf.thielow@gmail.com>
> ---
> Junio, thanks for the code in your reply to the
> first version. It works very well and looks nice.
> I was also unhappy about this "\n%c\n" thing and
> pretty unsure with the code in "git-submodule.sh".

I can't see anything wrong with it (but didn't have the time to test it). On my todo list (but *way* down) is the task to replace the call to "git submodule summary --for-status ..." in wt_status_print_submodule_summary() with a call to "git diff --submodule" (and - at least in the long term - rip out the --for-status option from the submodule script). Maybe now is a good time for someone else to tackle that? (especially as the new strbuf_commented_add*() functions should make that rather easy)

Previous: Junio C HamanoNext: Ralf Thielow
Message 15 of 18 in “commit: make default of "cleanup" option configurable”
  1. commit: make default of "cleanup" option configurableRalf Thielow, Jan 8, 2013
  2. Junio C HamanoJan 8, 2013
  3. Jonathan NiederJan 9, 2013
  4. Ralf ThielowJan 9, 2013
  5. Jonathan NiederJan 9, 2013
  6. Junio C HamanoJan 9, 2013
  7. Junio C HamanoJan 9, 2013
  8. Re* [PATCH] commit: make default of "cleanup" option configurableJunio C Hamano, Jan 10, 2013
  9. Allow custom "comment char"Ralf Thielow, Jan 15, 2013
  10. Junio C HamanoJan 15, 2013
  11. Junio C HamanoJan 16, 2013
  12. Ralf ThielowJan 16, 2013
  13. Allow custom "comment char"Ralf Thielow, Jan 16, 2013
  14. Junio C HamanoJan 16, 2013
  15. Jens LehmannJan 16, 2013
  16. [PATCHv2] commit: make default of "cleanup" option configurableRalf Thielow, Jan 9, 2013
  17. Junio C HamanoJan 10, 2013
  18. [PATCHv3] commit: make default of "cleanup" option configurableRalf Thielow, Jan 10, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.