Re: [PATCH] add warning for depth=0 in git clone.

From: Stefan Beller <stefanbeller@googlemail.com>
Date: Jan 8, 2013, 08:09 UTC
Message-ID: <50EBD453.9050101@googlemail.com>
In-Reply-To: <1357632422-5686-1-git-send-email-stefanbeller@googlemail.com>

Hi,

I am struggling a little with the development process, is a sign-off strictly required for git as it is for kernel development? If so here would be my sign-off:

Signed-off-by: Stefan Beller <stefanbeller@googlemail.com>

This adds a warning and the previous patch adds the documentation.

However I agree to Junio, that the meaning should actually depth=0 -> just the tip and no (0) other commits before.

depth=n -> the tip and n other commits before.

On 01/08/2013 09:07 AM, Stefan Beller wrote:

Show 19 quoted lines

> ---
>  builtin/clone.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/builtin/clone.c b/builtin/clone.c
> index ec2f75b..5e91c1e 100644
> --- a/builtin/clone.c
> +++ b/builtin/clone.c
> @@ -818,6 +818,9 @@ int cmd_clone(int argc, const char **argv, const char *prefix)
>  	remote = remote_get(option_origin);
>  	transport = transport_get(remote, remote->url[0]);
>  
> +	if (option_depth && transport->smart_options->depth < 1)
> +		die(_("--depth less or equal 0 makes no sense; read manpage."));
> +
>  	if (!is_local) {
>  		if (!transport->get_refs_list || !transport->fetch)
>  			die(_("Don't know how to clone %s"), transport->url);
>