Re: [RFH] NetBSD 6?

From: Stefano Lattarini <stefano.lattarini@gmail.com>
Date: Jan 3, 2013, 19:28 UTC
Message-ID: <50E5DBEB.9080009@gmail.com>
In-Reply-To: <rmiobh6rujt.fsf@fnord.ir.bbn.com>

On 01/03/2013 07:27 PM, Greg Troxel wrote:

Show 14 quoted lines

> 
> Junio C Hamano <gitster@pobox.com> writes:
> 
>> I forgot to mention that we also ship configure (and keep track of
>> configure.ac) so that optionally people can let autoconf machinery
>> to create config.mak.autogen to be included at the same place as
>> handcrafted config.mak in their build process.  I do not offhand
>> know if we do "for p in python python2.6 python2.7; do ..." kind of
>> thing, though.
> 
> pkgsrc uses the configure method, but it seems not to output a
> PYTHON_PATH.  It looks like automake's python.m4 is not used by git's
> configure.ac.
>

That is not surprising, since Git build system doesn't use Automake :-)

In addition, it's worth nothing that Automake's python support (both in its m4 and make components) is intended as an help to install python *modules* from Autotools-based packages; using it for mere stand-alone scripts would be overkill.

In the case of Git, an adapted version of something like this might be enough:

  AC_CHECK_PROGS([PYTHON], [python python2.7 python2.6 python2.5])
  if test -z "$PYTHON"; then
    AC_MSG_WARNING([python not found])
  fi

  $PYTHON -c 'check-not-py3k' || AC_MSG_WARNING([Python 3 is not supported])
  $PYTHON -c 'check-its-version' || AC_MSG_WARNING([python is too old])

(Automake itself uses, in its own build system, a similar idiom to look for a Perl interpreter at configure runtime).

Not my itch so far, but I will happily review a patch if anyone is willing to write it.

Show 10 quoted lines

> But pkgsrc passes PYTHON_PATH in the environment to make,
> so it works out currently.
> 
>> It refers to the type of the second parameter to iconv(); OLD_ICONV
>> makes it take "const char *", as opposed to "char *", the latter of
>> which matches
>>
>>   http://pubs.opengroup.org/onlinepubs/9699919799/functions/iconv.html
> 
> Thanks - I now see our extra const and am looking into it.

Regards,
  Stefano