Re: [PATCH] git-completion.bash: update obsolete code.

From: Manlio Perillo <manlio.perillo@gmail.com>
Date: Dec 17, 2012, 16:53 UTC
Message-ID: <50CF4E05.7050103@gmail.com>
In-Reply-To: <7vtxrlnuqr.fsf@alter.siamese.dyndns.org>

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Il 17/12/2012 05:54, Junio C Hamano ha scritto:

Show 12 quoted lines

> Manlio Perillo <manlio.perillo@gmail.com> writes:
> 
>> The git-completion.bash script was using the git ls-tree command
>> without the --name-only option, with a sed filter to parse path names;
>> use the --name-only option, instead.
>>
>> Signed-off-by: Manlio Perillo <manlio.perillo@gmail.com>
>> ---
> 
> Did you miss the different handling between blobs and trees the
> latter gets trailing slash in the completion)?
>

Yes, I totally missed it, sorry. I was assuming the bash completion script was written before --name-only option was added to ls-tree.

By the way, IMHO there should be an option for adding a slash to directory names in ls-tree.

> [...]

Regards  Manlio
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEUEARECAAYFAlDPTgUACgkQscQJ24LbaUSkKgCePH2NFHf/qp2ZrgI9eD9D0D3G zOwAmL8Dc8r9DevyV1ZhaCb2G9MPZxU= =QJEy -----END PGP SIGNATURE-----