Re: [PATCH] fsck: warn about ".git" in trees

From: Torsten Bögershausen <tboegi@web.de>
Date: Nov 30, 2012, 19:50 UTC
Message-ID: <50B90E11.8090501@web.de>
In-Reply-To: <20121128213529.GA16518@sigill.intra.peff.net>

Show 7 quoted lines

> Having a ".git" entry inside a tree can cause confusing
> results on checkout. At the top-level, you could not
> checkout such a tree, as it would complain about overwriting
> the real ".git" directory. In a subdirectory, you might
> check it out, but performing operations in the subdirectory
> would confusingly consider the in-tree ".git" directory as
> the repository.

[snip]

> +	int has_dotgit = 0;

Name like "." or ".." are handled as directories by the OS.

".git" could be a file or a directory, at least in theory, and from the OS point of view, but we want to have this as a reserved name.

Looking at bad directory names, which gives trouble when checking out:

Should we check for "/" or "../blabla" as well?