git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] remote-curl.c: Fix a compiler warning

From
Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Date
Nov 21, 2012, 19:08 UTC
Message-ID
<50AD26C3.2090407@ramsay1.demon.co.uk>

In particular, gcc issues an "'gzip_size' might be used uninitialized" warning (-Wuninitialized). However, this warning is a false positive, since the 'gzip_size' variable would not, in fact, be used uninitialized. In order to suppress the warning, we simply initialise the variable to zero in it's declaration.

Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
---
Hi Junio,

This is on top of next. (commit df126e108: "remote-curl: hoist gzip buffer size to top of post_rpc", 31-10-2012).

Thanks!

ATB, Ramsay Jones

 remote-curl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/remote-curl.c b/remote-curl.c
index d8b3600..9a8b123 100644
--- a/remote-curl.c
+++ b/remote-curl.c
@@ -400,7 +400,7 @@ static int post_rpc(struct rpc_state *rpc)
 	struct curl_slist *headers = NULL;
 	int use_gzip = rpc->gzip_request;
 	char *gzip_body = NULL;
-	size_t gzip_size;
+	size_t gzip_size = 0;
 	int err, large_request = 0;
 
 	/* Try to load the entire request, if we can fit it into the
-- 
1.8.0
Next: Jeff King
Message 1 of 2 in “remote-curl.c: Fix a compiler warning”
  1. remote-curl.c: Fix a compiler warningRamsay Jones, Nov 21, 2012
  2. Jeff KingNov 21, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.