Re: [regression] Newer gits cannot clone any remote repos

From: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Date: Nov 15, 2012, 19:17 UTC
Message-ID: <50A53FAC.8020401@ramsay1.demon.co.uk>
In-Reply-To: <50A2B2DF.1080704@web.de>

Torsten Bögershausen wrote:

Show 34 quoted lines

> On 13.11.12 19:55, Ramsay Jones wrote:
>> Douglas Mencken wrote:
>>> *Any* git clone fails with:
>>>
>>> fatal: premature end of pack file, 106 bytes missing
>>> fatal: index-pack failed
>>>
>>> At first, I tried 1.8.0, and it failed. Then I tried to build 1.7.10.5
>>> then, and it worked. Then I tried 1.7.12.2, but it fails the same way
>>> as 1.8.0.
>>> So I decided to git bisect.
>>>
>>> b8a2486f1524947f232f657e9f2ebf44e3e7a243 is the first bad commit
>>> ``index-pack: support multithreaded delta resolving''
>>
>> This looks like the same problem I had on cygwin, which lead to
>> commit c0f86547c ("index-pack: Disable threading on cygwin", 26-06-2012).
>>
>> I didn't notice which platform you are on, but maybe you also have a
>> thread-unsafe pread()? Could you try re-building git with the
>> NO_THREAD_SAFE_PREAD build variable set?
>>
>> HTH.
>>
>> ATB,
>> Ramsay Jones
> 
> This is interesting.
> I had the same problem on a PowerPC 
> (Old PowerBook G4 running Linux).
> 
> Using NO_THREAD_SAFE_PREAD helped, thanks for the hint.
> (After recompiling without NO_THREAD_SAFE_PREAD I could clone
> from this machine again, so the problem is not really reproducable)

Yes, the failures would be intermittent (and often not easily reproducible). The threaded index-pack code did not fail for me on cygwin at all during development, including tests, but failed immediately I installed v1.7.11. On real repositories, it failed intermittently. On some repos it always failed, on some it never failed and on some others it would sometimes fail, sometimes not.

ATB, Ramsay Jones