git/list[1] front-page[2] threads[3] people[4] search[5] about
 

"git imap-send" with HTML preformatting broken for multipart messages

From
Michael Haggerty <mhagger@alum.mit.edu>
Date
Nov 12, 2012, 08:43 UTC
Message-ID
<50A0B6A1.80101@alum.mit.edu>

I just noticed that "git imap-send" with imap.preformattedHTML turned on is broken for multipart messages. The problem is that "git imap-send" embeds *everything* after the main email header in <pre></pre> and HTML-escapes it, instead of splitting out the email parts and quoting their bodies individually.

Ironically, the "git imap-send" manpage specifically lists the typical usage as

    git format-patch --signoff --stdout --attach origin | git imap-send
which is broken if imap.preformattedHTML is set.

It seems to me that rather than fix "git imap-send" (which would require it to become more complicated), it would be better to teach "git format-patch" how to do preformatting and restrict "git imap-send" to sending messages verbatim to an IMAP server. Moving the functionality to "git format-patch" would also make it possible to create preformatted emails to be used with other transports.

Oh, and, by the way, "git imap-send" is utterly untested by the test suite. The fact that it is intrinsically hard to test without lots of extra infrastructure is another argument for making it as stupid as possible.

I don't plan to work on this.
Michael
-- 
Michael Haggerty
mhagger@alum.mit.edu
http://softwareswirl.blogspot.com/
Message 1 of 1 in “"git imap-send" with HTML preformatting broken for multipart messages”
  1. Michael HaggertyNov 12, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.