Re: [PATCH] gitk: use config settings for head/tag colors

From: Johannes Sixt <j6t@kdbg.org>
Date: Jan 20, 2026, 16:02 UTC
Message-ID: <509acce4-d1d0-4c18-8c42-7ebe84594a92@kdbg.org>
In-Reply-To: <SJ1SPRMB0003BF77E3500DF7C96E3042D18CA@SJ1SPRMB0003.namprd20.prod.outlook.com>

Am 15.01.26 um 07:03 schrieb Shannon Barber:

Show 11 quoted lines

> I think I can simplify it to :
>>  gitk: honor the headoutlinecolor and tagfgcolor config settings
> I pushed a fix with a corrected sign-off.
> 
> These settings already exist but the code ignored them.
> 
> I do not understand your question about a high-level summary.
> There are no structural changes.
> There are no functional changes.
> This is a cosmetic change to how the head and tag refs are drawn, to use
> already existing color configurations (that were inadvertently ignored.)

While the effect of the change is just cosmetic (in the sense that the visual appearance of the graph labels is changed), it is not a "no functional change".

Consider a user who has experimented with the configuration file. They may have found that changing the value of these variables in the file doesn't work, and then forgot about it, leaving the modified value in the file. With this change, the value that was so far ignored, now suddenly has an effect. It is worthwhile to analyze such behavior and document it at least in the commit message, so that later readers of the code and history know that the case was considered.

You should think about such effects and note them in the commit message.
Include the expected behavior in such edge cases. That's what I meant by
 high-level summary.

-- Hannes