Re: crash on git diff-tree -Ganything <tree> for new files with textconv filter

From: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Date: Nov 1, 2012, 19:19 UTC
Message-ID: <5092CB40.3090707@ramsay1.demon.co.uk>
In-Reply-To: <20121030121747.GA4231@sigill.intra.peff.net>

Jeff King wrote:

Show 9 quoted lines

> Thinking on it more, my patch, hacky thought it seems, may not be the
> worst solution. Here are the options that I see:
> 
>   1. Use a regex library that does not require NUL termination. If we
>      are bound by the regular regexec interface, this is not feasible.
>      But the GNU implementation works on arbitrary-length buffers (you
>      just have to use a slightly different interface), and we already
>      carry it in compat. It would mean platforms which provide a working
>      but non-GNU regexec would have to start defining NO_REGEX.

I have thought about the possibility of doing this for unrelated reasons in the past.

On cygwin, there have been two unexpected test passes since about v1.6.0 (I reported it to the list in passing), like so:

    [ ... ]
    All tests successful.

    Test Summary Report
    -------------------
    t0050-filesystem.sh                              (Wstat: 0 Tests: 9 Failed: 0)
      TODO passed:   5
    t7008-grep-binary.sh                             (Wstat: 0 Tests: 20 Failed: 0)
      TODO passed:   12
    Files=604, Tests=8439, 11190 wallclock secs ( 2.59 usr  1.59 sys + 7294.86 cusr
    3416.65 csys = 10715.70 CPU)
    Result: PASS

In particular, t7008.12 passes on cygwin because the regex library apparently matches '.' to NUL. Indeed if you add a test_pause to the script and execute "grep .fi a" (note grep *not* git-grep) then "Binary file a matches" on Linux, cygwin and MinGW. (So I assume the test was added to document a difference in behaviour to GNU grep).

So, if we use the GNU interface to the regex routines in compat, then we may specify the "grep syntax" for use in git-grep. (Well that's the theory, I've not actually tried to code it up, so take this with a pinch of salt! :-P ).

ATB, Ramsay Jones