git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] Teach --recursive to submodule sync

From
Jens Lehmann <jens.lehmann@web.de>
Date
Oct 26, 2012, 18:50 UTC
Message-ID
<508ADB6B.5040905@web.de>
In-Reply-To
<CABURp0q0uELTS4DQ=Kqfr+8Pr-KgLcGJaBY_kJE_AiO=BZu+Bw@mail.gmail.com>
Am 26.10.2012 19:55, schrieb Phil Hord:
Show 7 quoted lines
> On Fri, Oct 26, 2012 at 1:19 PM, Phil Hord <hordp@cisco.com> wrote:
>>
>> Yes, thanks for catching that.  I think I should add a test for that
>> except I notice that sync doesn't take any other flags useful for passing.
> 
> Which, of course, suggests that I should not add this
> flag-propagating-machinery to submodule-sync at all. yes?
Nope, the new --recursive option has to be passed on!

To catch that bug in your test you'd need another submodule inside your sub-submodule. The first level submodule is initialized by sync anyways, the sub-submodule is initialized by the --recursive logic you added but the sub-sub-submodule would not have been synced because the option was dropped. I really can't blame you for not adding that third level of submodules ;-)

Previous: Phil HordNext: Phil Hord
Message 8 of 12 in “git submodule sync --recursive”
  1. Phil HordOct 16, 2012
  2. Jens LehmannOct 17, 2012
  3. Phil HordOct 23, 2012
  4. 1/2 Teach --recursive to submodule syncPhil Hord, Oct 23, 2012
  5. Jens LehmannOct 25, 2012
  6. Phil HordOct 26, 2012
  7. Phil HordOct 26, 2012
  8. Jens LehmannOct 26, 2012
  9. 0/2 Reroll submodule sync --recursivePhil Hord, Oct 26, 2012
  10. 1/2 Teach --recursive to submodule syncPhil Hord, Oct 26, 2012
  11. 2/2 Add tests for submodule sync --recursivePhil Hord, Oct 26, 2012
  12. 2/2 Add tests for submodule sync --recursivePhil Hord, Oct 23, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.