Re: Subtree in Git
- From
- Herman van Rink <rink@initfour.nl>
- Date
- Oct 26, 2012, 13:10 UTC
- Message-ID
- <508A8BD3.9020901@initfour.nl>
- In-Reply-To
- <nnga9vefu1v.fsf@transit.us.cray.com>
On 10/22/2012 04:41 PM, dag@cray.com wrote:
Show 29 quoted lines
> Herman van Rink <rink@initfour.nl> writes: > >> On 10/21/2012 08:32 AM, Junio C Hamano wrote: >>> Herman van Rink <rink@initfour.nl> writes: >>> >>>> Junio, Could you please consider merging the single commit from my >>>> subtree-updates branch? https://github.com/helmo/git/tree/subtree-updates >>> In general, in areas like contrib/ where there is a volunteer area >>> maintainer, unless the change something ultra-urgent (e.g. serious >>> security fix) and the area maintainer is unavailable, I'm really >>> reluctant to bypass and take a single patch that adds many things >>> that are independent from each other. >> Who do you see as volunteer area maintainer for contrib/subtree? >> My best guess would be Dave. And he already indicated earlier in the >> thread to be ok with the combined patch as long as you are ok with it. > Let's be clear. Junio owns the project so what he says goes, no > question. I provided some review feedback which I thought would help > the patches get in more easily. We really shouldn't be adding multiple > features in one patch. This is easily separated into multiple patches. > > Then there is the issue of testcases. We should NOT have git-subtree go > back to the pre-merge _ad_hoc_ test environment. We should use what the > usptream project uses. That will make mainlining this much easier in > the future. > > If Junio is ok with overriding my decisions here, that's fine. But I > really don't understand why you are so hesitant to rework the patches > when it should be realtively easy. Certainly easier than convincing me > they are in good shape currently. :)
If it's so easy to rework these patches then please do so yourself. It's been ages since I've worked on this so I would also have to re-discover everything.
And yes it's ugly, but so is the code that you've merged in. Which you haven't changed a single line in after merging. So it's still the version from Avery which hasn't been maintained for the last two years.
This ball of wax is still a big improvement in my opinion.
Feel free to scrape the github forks for improvements on your own, cleanup the code style and create fitting test cases. But if you intend on taking in changes only when presented to you on a silver patter, then we're better of with subtree removed from the contrib tree.
What would a random user have to do to get a patch in? I've found a number of subtree related mails on the git-user list go completely unanswerd. Amongst them a patch from James Nylen wich seems very reasonable.
-- Met vriendelijke groet / Regards, Herman van Rink Initfour websolutions