git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/5] Cure some format-patch wrapping and encoding issues

From
JSJan H. Schönherr <schnhrr@cs.tu-berlin.de>
Date
Oct 10, 2012, 10:49 UTC
Message-ID
<507552C8.2020402@cs.tu-berlin.de>
In-Reply-To
<7vfw5nfoq9.fsf@alter.siamese.dyndns.org>
Am 09.10.2012 21:07, schrieb Junio C Hamano:
Show 6 quoted lines
> Jan H. Schönherr <schnhrr@cs.tu-berlin.de> writes:
> 
>> During the creation of this series, I came across the strbuf 
>> wrapping functions, and I wonder if there is an off-by-one issue.
>>
>> Consider the following excerpt from t4202:
...
Show 6 quoted lines
> 
> Yeah, that does sound like an off-by-one bug.  When we as end users
> say %w(72), we do expect some lines fill to the 72nd column, not
> stopping at the 71st.  I suspect that dates back to the very first
> implementation of %w() but I think we should fix it (perhaps as a
> separate patch either the earliest or the last in the series).
I will include a fix for that, then.

(But I won't be able the send out the next round of this series before next week.)

Regards Jan

Previous: Junio C Hamano
Message 10 of 10 in “Cure some format-patch wrapping and encoding issues”
  1. 0/5 Cure some format-patch wrapping and encoding issuesJan H. Schönherr, Oct 8, 2012
  2. 1/5 format-patch: do not wrap non-rfc2047 headers too earlyJan H. Schönherr, Oct 8, 2012
  3. 2/5 format-patch: do not wrap rfc2047 encoded headers too lateJan H. Schönherr, Oct 8, 2012
  4. 3/5 format-patch: introduce helper function last_line_length()Jan H. Schönherr, Oct 8, 2012
  5. 4/5 format-patch: fix rfc2047 address encoding with respect to rfc822 specialsJan H. Schönherr, Oct 8, 2012
  6. 5/5 format-patch: tests: check rfc822+rfc2047 in to+cc headersJan H. Schönherr, Oct 8, 2012
  7. Jan H. SchönherrOct 10, 2012
  8. Jan H. SchönherrOct 10, 2012
  9. Junio C HamanoOct 10, 2012
  10. Jan H. SchönherrOct 10, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.