Re: [PATCH] Fix default font scaling

From: Johannes Sixt <j6t@kdbg.org>
Date: Jun 23, 2024, 09:13 UTC
Message-ID: <506e1f16-ac02-496c-a9dc-414726c1c37f@kdbg.org>
In-Reply-To: <3M5FFS.HXL15VW2HPOG1@gmail.com>

Am 21.06.24 um 09:18 schrieb Serhii Tereshchenko:

Show 10 quoted lines

> Thanks! I tried booting into Fedora/37 with the same Tk version, and it
> indeed does not have this scaling problem.
> 
> Then, I downgraded packages on Arch to 8.6.12 and 8.6.13 - also no problem.
> 
> The only version affected is 8.6.14.
> 
> That's probably a bug in Tk (and there's quite a few reported, mostly
> about "tk scaling" https://core.tcl-lang.org/tk/info/1de3a48312, we
> don't use it explicitly in git-gui but on my system it is set to 1.3)

What is the best course of action now? Since this change does not make things any different for me on Linux+KDE, I am inclined to pick up this patch with a modified commit message and code comment that clearly state that this is a work-around for a bug in Tk introduced in 8.6.14. This would help users who upgrade from an earlier version of Tk, because it does not look like a fix of Tk is in the works (or that the issue is regarded as a regression by Tk people at all).

Suggestions?

-- Hannes